Fix caching of dependencies during re-entrancy #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem introduced in #235 that can cause dependencies to not be cached when first accessed in a re-entrant fashion. This can happen if while resolving a dependency one synchronously accesses another dependency:
The act of touching
innerDependency
synchronously while resolvingOuterDependency
causes re-entrancy into the cache of dependencies. And because #235 started protecting that cache withLockIsolated.withValue { … }
, that causes the resolution ofinnerDependency
to not be cached.For now we will go back to protecting this state with a separate lock + mutable value, but in the future we may consider not allowing this kind of re-entrance into the cache. I think it's very subtle, and there are other ways of accomplishing this while avoiding re-entrancy.